Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.26] Change kubelet args passed in CLI inttest #3512

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[Backport release-1.26] Change kubelet args passed in CLI inttest #3512

merged 1 commit into from
Sep 21, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Sep 21, 2023

@twz123
Change kubelet args passed in CLI inttest
1ce3f1a 
The randomly selected kubelet arguments used in the CLI inttest lead to
kubelet crash-looping on 6.x kernels (observed on 6.1 and 6.2), whereas
they worked just fine on 5.15 kernels. Since GitHub updated the kernels
of its Ubuntu managed GitHub action runners from 5.15 to 6.2 a few days
ago, the CLI test started to fail constantly.

Select some other flags that won't induce a crash-loop for the test.
Also make a slight improvement to the command line assertion: Check for
whole args instead of substrings, and use the right testing.T pointer to
report failures on.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
(cherry picked from commit f22108f)
(cherry picked from commit 7c349c9)
@twz123 twz123 added bug Something isn't working area/smoke-tests backport/release-1.25 PR that needs to be backported/cherrypicked to release-1.25 branch labels Sep 21, 2023
@twz123 twz123 mentioned this pull request Sep 21, 2023
Merged
@twz123 twz123 marked this pull request as ready for review September 21, 2023 13:16
@twz123 twz123 requested a review from a team as a code owner September 21, 2023 13:16
@twz123 twz123 requested review from ncopa and kke September 21, 2023 13:16
@twz123 twz123 merged commit f2a90cd into k0sproject:release-1.26 Sep 21, 2023
69 checks passed
@twz123 twz123 deleted the backport-3511-to-release-1.26 branch September 21, 2023 13:16
@k0s-bot
Copy link

k0s-bot commented Sep 21, 2023

Backport failed for release-1.25, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.25
git worktree add -d .worktree/backport-3512-to-release-1.25 origin/release-1.25
cd .worktree/backport-3512-to-release-1.25
git checkout -b backport-3512-to-release-1.25
ancref=$(git merge-base 51fbf4e152cea2038a122ac92df3280a3f71d5e4 1ce3f1a3b71b282f70d81dac4531f9a71bfcba28)
git cherry-pick -x $ancref..1ce3f1a3b71b282f70d81dac4531f9a71bfcba28

@k0s-bot k0s-bot mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/smoke-tests backport/release-1.25 PR that needs to be backported/cherrypicked to release-1.25 branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @jnummelin