Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unix build tag #4042

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Use unix build tag #4042

merged 1 commit into from
Mar 12, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 8, 2024

Description

Use the unix build tag instead of !windows. Rename all the files using this build tag to use the _unix suffix. This brings the file name suffixes and the build tags they use in sync. Moreover, remove the _shared file suffix for files that are compiled unconditionally.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Feb 8, 2024
@twz123 twz123 marked this pull request as ready for review February 8, 2024 18:31
@twz123 twz123 requested a review from a team as a code owner February 8, 2024 18:31
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

juanluisvaladas
juanluisvaladas previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@juanluisvaladas juanluisvaladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This pull request has merge conflicts that need to be resolved.

@twz123
Use unix build tag
373da61 
Use the unix build tag instead of !windows. Rename all the files using
this build tag to use the _unix suffix. This brings the file name
suffixes and the build tags they use in sync. Moreover, remove the
_shared file suffix for files that are compiled unconditionally.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 merged commit b646e9f into k0sproject:main Mar 12, 2024
73 checks passed
@twz123 twz123 deleted the unix-build-tag branch March 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @juanluisvaladas