Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.28] Error out when NLLB is enabled for a single-node cluster #4098

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[Backport release-1.28] Error out when NLLB is enabled for a single-node cluster #4098

merged 1 commit into from
Feb 21, 2024

Conversation

k0s-bot
Copy link

@k0s-bot k0s-bot commented Feb 20, 2024 •
edited by twz123
Loading

Automated backport to release-1.28, triggered by a label in #4096.
See #4056.

@twz123 @github-actions
Error out when NLLB is enabled for a single-node cluster
37ad6f5 
Using NLLB in a single-node cluster was never supported and documented
as such since the inception of NLLB. K0s didn't error out early in this
case, though.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
(cherry picked from commit 7b7f94f)
(cherry picked from commit 953358b)
@k0s-bot k0s-bot requested a review from a team as a code owner February 20, 2024 22:00
@k0s-bot k0s-bot requested review from kke and makhov February 20, 2024 22:00
@k0s-bot k0s-bot mentioned this pull request Feb 20, 2024
Merged
@twz123 twz123 changed the title [Backport release-1.28] [Backport release-1.29] Error out when NLLB is enabled for a single-node cluster [Backport release-1.28] Error out when NLLB is enabled for a single-node cluster Feb 20, 2024
@twz123 twz123 added bug Something isn't working area/configuration backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch labels Feb 20, 2024
@twz123 twz123 merged commit d83e1fe into release-1.28 Feb 21, 2024
74 checks passed
@twz123 twz123 deleted the backport-4096-to-release-1.28 branch February 21, 2024 08:10
@k0s-bot
Copy link
Author

k0s-bot commented Feb 21, 2024

Successfully created backport PR for release-1.27:

@k0s-bot k0s-bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/configuration backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k0s-bot @jnummelin @twz123