[Backport release-1.26] bug: retry saving helm chart object status #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we fail to save the status, specially after installing the chart, we will try to install the chart again during the next reconcile (its Status.Status.ReleaseName will be empty). this pr attempts to mitigate this in two ways: - before updating fetch the newest version of the chart. - retry if it is still on conflict. this may be overkill as it most likely won't fail after we fetch an updated version of the chart but given the importance of this operation we better be safe than sorry. when this bug this solves happens this is what is reported in the chart status: ``` can't install loadedChart ```chart-name```: cannot re-use a name that is still in use ``` Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com> (cherry picked from commit 5333b91)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.26, triggered by a label in #4064.See #4047.