[Backport release-1.30] Cleanup unknown Helm chart manifest files #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the reconciliation gets as close as possible to the desired state, even if some things in between are failing. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit e0aa6a4)
This is an internal implementation detail of the extensions controller and not an inherent property of the chart resource. Hence move the func into the controller and make it private. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit 394418d)
Keep track of the generated filenames when reconciling Helm Chart extensions. After all files have been synchronized, remove any remaining unknown Helm chart manifest files. This way the synchronization will work correctly even if the Helm chart extension names and orders are changed. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit c1f8c75)
twz123
added
bug
ncopa
approved these changes
Jul 8, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.29
git worktree add -d .worktree/backport-4717-to-release-1.29 origin/release-1.29
cd .worktree/backport-4717-to-release-1.29
git switch --create backport-4717-to-release-1.29
git cherry-pick -x 9db7b1e8eb2a7a093c7a42326822f3feb02c5b05 966dc5ec0b9658c04dab2f66f44a17e374ba4100 0e4db6a3b3db821884070448b10d99448632a443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.30:See: