Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vfio-pci: add dependency on vfio-pci-core #7

Closed

Conversation

pprindeville
Copy link
Contributor

vfio-pci depends on vfio-pci-core

@zokl
Copy link
Contributor

zokl commented May 17, 2023

Hello, your PR is for the master version of OpenWRT, stable branch 22.03 is without vfio support, and the used kernel does not include the Vfio-pci-core module. I check the necessary of my own vfio modules for the master version of OpenWrt.

@pprindeville
Copy link
Contributor Author

pprindeville commented May 17, 2023

The intention is to rationalize what's already in master with the additional support needed for DPDK and get everything in one place upstream.

Since vfio and vfio-pci are already built in master, all that's really necessary is packaging for the user-space runtime.

@pprindeville
Copy link
Contributor Author

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

@zokl
Copy link
Contributor

zokl commented May 17, 2023

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

@pprindeville
Copy link
Contributor Author

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

@zokl
Copy link
Contributor

zokl commented May 17, 2023

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

Yes, this issue is for last master's version of 22.03.

@pprindeville
Copy link
Contributor Author

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

Yes, this issue is for last master's version of 22.03.

I can't reproduce it.

@pprindeville
Copy link
Contributor Author

Have you tried building with MUSL? That's what most of OpenWRT builds with.

@zokl
Copy link
Contributor

zokl commented May 17, 2023

Okay, can I take your kmod-iommu_v2 directory and make a PR to upstream it into master?

Yes, it is possible to make a PR but at first I need to resolve this glibc issue openwrt/openwrt#12631 and test everything over our codes.

That's for 22.03? I'm talking about merging to master where we're not seeing this issue.

Yes, this issue is for last master's version of 22.03.

I can't reproduce it.

I have fresh openwrt master environment with glibc enabled.

@zokl
Copy link
Contributor

zokl commented May 17, 2023

Have you tried building with MUSL? That's what most of OpenWRT builds with.

Musl works without problem. GLIBC has a problem. I am not able to compile DPDK on musl version of OpenWRT. I need to use GLIBC version.

@zokl
Copy link
Contributor

zokl commented May 17, 2023

Have you tried building with MUSL? That's what most of OpenWRT builds with.

Musl works without problem. GLIBC has a problem. I am not able to compile DPDK on musl version of OpenWRT. I need to use GLIBC version.

I use this tutorial: https://github.com/k13132/openwrt-dpdk/blob/main/README.md

@pprindeville
Copy link
Contributor Author

pprindeville commented May 17, 2023

Have you tried building with MUSL? That's what most of OpenWRT builds with.

Musl works without problem. GLIBC has a problem. I am not able to compile DPDK on musl version of OpenWRT. I need to use GLIBC version.

Because of the <execinfo.h> issue? Yeah, I'm working on a patch for that...

The issue there is that we're using the canned settings in config/rte_config.h for RTE_BACKTRACE, for instance. That should only be set if CONFIG_LIBC == glibc (or CONFIG_USE_GLIBC, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants