Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for invalid validator instance after validation error. #884

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Apr 21, 2024

ref: #882

@k1LoW k1LoW added the bug Something isn't working label Apr 21, 2024
@k1LoW k1LoW self-assigned this Apr 21, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #884 (f3f9fdd) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,788,940,191 ns/op 3,736,029,128 ns/op -52,911,063 ns/op
Bytes allocated per iteration 1,791,889,328 B/op 1,791,971,096 B/op 81,768 B/op
Allocs per iteration 21,406,473 allocs/op 21,406,152 allocs/op -321 allocs/op
Metadata
main (-) #884 (f3f9fdd)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #884 (f3f9fdd) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,338,347,996 ns/op 5,348,764,063 ns/op 10,416,067 ns/op
Bytes allocated per iteration 3,232,167,360 B/op 3,232,330,560 B/op 163,200 B/op
Allocs per iteration 31,160,637 allocs/op 31,162,250 allocs/op 1,613 allocs/op
Metadata
main (-) #884 (f3f9fdd)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #884 (f3f9fdd) +/-
Number of iterations 18 18 0
Nanoseconds per iteration 74,026,879 ns/op 64,991,973 ns/op -9,034,906 ns/op
Bytes allocated per iteration 60,160,082 B/op 60,165,226 B/op 5,144 B/op
Allocs per iteration 205,637 allocs/op 205,652 allocs/op 15 allocs/op
Metadata
main (-) #884 (f3f9fdd)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (ad54e1c) #884 (f3f9fdd) +/-
Coverage 65.9% 65.9% +0.0%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 4m17s 3m47s -30s
Details
  |                     | main (ad54e1c) | #884 (f3f9fdd) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          65.9% |          65.9% | +0.0% |
  |   Files             |             71 |             71 |     0 |
  |   Lines             |           7596 |           7606 |   +10 |
+ |   Covered           |           5003 |           5011 |    +8 |
+ | Code to Test Ratio  |          1:0.7 |          1:0.7 |  +0.0 |
  |   Code              |          13710 |          13724 |   +14 |
+ |   Test              |          10128 |          10250 |  +122 |
+ | Test Execution Time |          4m17s |          3m47s |  -30s |

Code coverage of files in pull request scope (81.2% → 81.2%)

Files Coverage +/-
http_validator.go 81.2% -0.1%

Reported by octocov

@k1LoW k1LoW merged commit 17461c9 into main Apr 21, 2024
7 checks passed
@k1LoW k1LoW deleted the fix-882 branch April 21, 2024 22:43
@github-actions github-actions bot mentioned this pull request Apr 21, 2024
k1LoW added a commit to k1LoW/httpstub that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants