Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dump.disableTrailingNewline: for disabling trailing newline in dump output #931

Merged
merged 1 commit into from
May 20, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented May 20, 2024

Also fully unified normal and file output content.

…dump output

Also fully unified normal and file output content.
@k1LoW k1LoW self-assigned this May 20, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #931 (edf27e8) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,999,138,762 ns/op 4,084,811,133 ns/op 85,672,371 ns/op
Bytes allocated per iteration 1,792,908,648 B/op 1,792,893,216 B/op -15,432 B/op
Allocs per iteration 21,406,610 allocs/op 21,406,269 allocs/op -341 allocs/op
Metadata
main (-) #931 (edf27e8)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #931 (edf27e8) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,206,252,999 ns/op 5,199,076,989 ns/op -7,176,010 ns/op
Bytes allocated per iteration 2,952,516,352 B/op 2,952,793,048 B/op 276,696 B/op
Allocs per iteration 29,381,179 allocs/op 29,383,819 allocs/op 2,640 allocs/op
Metadata
main (-) #931 (edf27e8)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #931 (edf27e8) +/-
Number of iterations 16 16 0
Nanoseconds per iteration 75,836,983 ns/op 67,195,532 ns/op -8,641,451 ns/op
Bytes allocated per iteration 60,321,166 B/op 60,294,610 B/op -26,556 B/op
Allocs per iteration 205,781 allocs/op 205,766 allocs/op -15 allocs/op
Metadata
main (-) #931 (edf27e8)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (db0c724) #931 (edf27e8) +/-
Coverage 64.1% 64.1% +0.0%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Test Execution Time 6m6s 6m3s -3s
Details
  |                     | main (db0c724) | #931 (edf27e8) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          64.1% |          64.1% | +0.0% |
  |   Files             |             75 |             75 |     0 |
  |   Lines             |           8175 |           8182 |    +7 |
+ |   Covered           |           5237 |           5244 |    +7 |
+ | Code to Test Ratio  |          1:0.5 |          1:0.5 |  +0.0 |
  |   Code              |          23538 |          23551 |   +13 |
+ |   Test              |          11167 |          11198 |   +31 |
+ | Test Execution Time |           6m6s |           6m3s |   -3s |

Code coverage of files in pull request scope (79.4% → 79.4%)

Files Coverage +/-
dump.go 69.4% +0.5%
operator.go 79.9% +0.1%

Reported by octocov

@k1LoW k1LoW merged commit 5f0ff72 into main May 20, 2024
8 checks passed
@k1LoW k1LoW deleted the disable-trailing-newline branch May 20, 2024 12:16
@k1LoW k1LoW added the minor label May 20, 2024
@github-actions github-actions bot mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant