Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal improvements for the next features. #987

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Internal improvements for the next features. #987

merged 8 commits into from
Jul 10, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jul 9, 2024

SSIA.

k1LoW added 3 commits July 9, 2024 09:44
Assuming future implementation of the `needs:` section, even Run cannot guarantee that only one runbook is executed.
@k1LoW k1LoW self-assigned this Jul 9, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

BenchmarkManyRunbooks-4

main (-) #987 (2eece94) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,789,185,036 ns/op 3,868,435,508 ns/op 79,250,472 ns/op
Bytes allocated per iteration 1,793,668,056 B/op 1,736,595,064 B/op -57,072,992 B/op
Allocs per iteration 21,426,461 allocs/op 21,135,784 allocs/op -290,677 allocs/op
Metadata
main (-) #987 (2eece94)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #987 (2eece94) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,254,941,602 ns/op 5,125,942,623 ns/op -128,998,979 ns/op
Bytes allocated per iteration 3,139,474,744 B/op 3,138,684,920 B/op -789,824 B/op
Allocs per iteration 29,704,217 allocs/op 29,700,814 allocs/op -3,403 allocs/op
Metadata
main (-) #987 (2eece94)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #987 (2eece94) +/-
Number of iterations 18 18 0
Nanoseconds per iteration 66,075,462 ns/op 69,178,275 ns/op 3,102,813 ns/op
Bytes allocated per iteration 60,275,564 B/op 60,228,656 B/op -46,908 B/op
Allocs per iteration 205,860 allocs/op 205,577 allocs/op -283 allocs/op
Metadata
main (-) #987 (2eece94)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Code Metrics Report

main (2f0c5fb) #987 (2eece94) +/-
Coverage 64.0% 64.0% -0.1%
Code to Test Ratio 1:0.4 1:0.4 -0.1
Test Execution Time 5m36s 5m21s -15s
Details
  |                     | main (2f0c5fb) | #987 (2eece94) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          64.0% |          64.0% | -0.1% |
  |   Files             |             78 |             78 |     0 |
  |   Lines             |           8555 |           8562 |    +7 |
+ |   Covered           |           5483 |           5486 |    +3 |
- | Code to Test Ratio  |          1:0.4 |          1:0.4 |  -0.1 |
  |   Code              |          24227 |          24249 |   +22 |
  |   Test              |          11586 |          11586 |     0 |
+ | Test Execution Time |          5m36s |          5m21s |  -15s |

Code coverage of files in pull request scope (71.2% → 71.1%)

Files Coverage +/-
operator.go 79.6% -0.3%
option.go 58.4% 0.0%
result.go 70.8% +0.2%
store.go 76.7% +0.1%

Reported by octocov

@k1LoW k1LoW merged commit fb0a47c into main Jul 10, 2024
8 checks passed
@k1LoW k1LoW deleted the bonsai branch July 10, 2024 02:34
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
@k1LoW k1LoW added minor and removed minor labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant