Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING][PostgreSQL][Amazon Redshift]Show public. schema #175

Merged
merged 9 commits into from
Mar 7, 2020

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Mar 6, 2020

Because public. is NOT default schema name.
( see "5.9.3. The Schema Search Path" )

@k1LoW k1LoW self-assigned this Mar 6, 2020
@k1LoW
Copy link
Owner Author

k1LoW commented Mar 6, 2020

link: #173

@k1LoW k1LoW changed the title [BREAKING][PostgreSQL][Redshift]Show public. schema [BREAKING][PostgreSQL][Amazon Redshift]Show public. schema Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #175 into master will decrease coverage by 0.66%.
The diff coverage is 46.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   68.49%   67.82%   -0.67%     
==========================================
  Files          16       16              
  Lines        2977     3009      +32     
==========================================
+ Hits         2039     2041       +2     
- Misses        730      760      +30     
  Partials      208      208
Impacted Files Coverage Δ
datasource/datasource.go 16.75% <ø> (-14.06%) ⬇️
output/config/config.go 50% <12.5%> (+2.54%) ⬆️
drivers/sqlite/sqlite.go 85.3% <50%> (-0.56%) ⬇️
schema/schema.go 36.43% <50%> (+0.14%) ⬆️
drivers/dynamo/dynamo.go 84.68% <50%> (+3.73%) ⬆️
drivers/mssql/mssql.go 82.38% <50%> (-0.49%) ⬇️
drivers/mysql/mysql.go 81.38% <50%> (-0.61%) ⬇️
drivers/postgres/postgres.go 70.57% <64%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f73c9...cb78617. Read the comment docs.

@k1LoW k1LoW marked this pull request as ready for review March 7, 2020 02:04
@k1LoW k1LoW merged commit 74119e0 into master Mar 7, 2020
@k1LoW k1LoW deleted the show-public-schema-name branch March 7, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant