Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add numerical gradient check tests and ctc loss test #577

Merged
merged 6 commits into from
Jan 11, 2021
Merged

add numerical gradient check tests and ctc loss test #577

merged 6 commits into from
Jan 11, 2021

Conversation

csukuangfj
Copy link
Collaborator

No description provided.

@danpovey
Copy link
Collaborator

danpovey commented Jan 9, 2021

Great work!
Don't see any obvious problems.. merge if you think it's ready...

@csukuangfj csukuangfj changed the title add numerical gradient check tests add numerical gradient check tests and ctc loss test Jan 9, 2021
@csukuangfj
Copy link
Collaborator Author

gradient tests for CTC loss are also added.

@danpovey please have a second review.

Conclusion : k2, PyTorch, and warp-ctc produce identical losses when given identical inputs.

@csukuangfj csukuangfj mentioned this pull request Jan 9, 2021
Closed
@csukuangfj
Copy link
Collaborator Author

Merging.

@csukuangfj csukuangfj merged commit a78ef01 into k2-fsa:master Jan 11, 2021
@csukuangfj csukuangfj deleted the fangjun-gradient-check branch January 11, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csukuangfj @danpovey