-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move connect topsort addepsilonselfloops to C++ #838
Conversation
pkufool
commented
Oct 1, 2021
•
edited
Loading
edited
- Move connect to C++
- Move top_sort to C++
- Move add_epsilon_self_loops to C++
- Refine CreateFsaVec
- Refine ToString
… for CreateFsaVec
Ready for reviewing, will submit other code to another PR to avoid making a too big pull request. |
I have a general concern with this direction that it is making things less easy to understand. |
After writing #839, i.e, to run a pre-trained model in C++, I realized we actually don't There are the pros and cons I can think of about moving everything to C++. Pros
Cons
But @pkufool has started the work and put some effort in this way. |
I think the key point is how we deal with Fsa class, we need Fsa class to propagate attributes for both training and decoding. Can we keep two versions of Fsa class, python for training and C++ for decoding. Obviously, the C++ version will be less complicated, we don't need to implement autograd thing. |
I agree that having 2 versions of the code (python and C++) is probably the best solution for now. |
See the comments above, closing this pull request. |