Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix install.sh script for windows (mingw/msys2 bash).
Why
The install script wasn't working on windows b/c the released binary for windows has a .exe extension on it which made the script error with a 404. Also, the USE_SUDO variable should be set to false by default on windows (otherwise piping script to bash won't work).
Implications
An alternative fix would be to change the releases to not include the .exe extension on the windows binary but maybe that was done for use outside of mingw where the install.sh script wouldn't be used. The install script still saves k3d to /usr/local/bin/k3d without the .exe extension and it works without the .exe extension (in msys2/mingw). It would work the same way if it was saved as k3d.exe.