fix: handle colima host #1228
Merged
fix: handle colima host #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k3d mostly works flawlessly on github.com/abiosoft/colima, but host.k3d.interal points to nowhere useful. We detect colima runtime by the name in docker info output, then resolve the host IP by querying host.lima.internal. How to test: $ colima start $ k3d cluster create $ nc -l 0.0.0.0 1234 In another terminal $ kubectl run -it --rm --image alpine:latest test -- \ /bin/sh -c 'echo "hello there" | nc host.k3d.internal 1234'
iwilltry42
approved these changes
Mar 9, 2023
|
That's a nice addition, thank you @thejan2009 ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k3d mostly works flawlessly on github.com/abiosoft/colima, but host.k3d.interal points to nowhere useful. We detect colima runtime by the name in docker info output, then resolve the host IP by querying host.lima.internal.
How to test:
$ colima start
$ k3d cluster create
$ nc -l 0.0.0.0 1234
In another terminal
$ kubectl run -it --rm --image alpine:latest test -- /bin/sh -c 'echo "hello there" | nc host.k3d.internal 1234'
What
Fixes HostIP detection when running on Colima.
Why
To fix host.k3d.internal
Implications
Unsure. Works on my machine with the patch...