Adds json response of version info#1262
Merged
iwilltry42 merged 2 commits intok3d-io:mainfrom May 17, 2023
Merged
Conversation
iwilltry42
requested changes
May 17, 2023
Member
iwilltry42
left a comment
iwilltry42
left a comment
There was a problem hiding this comment.
Looks good, thank you! Just a small change regarding the flag name requested.
Member
|
@all-contributors please add @dgershman for code |
Contributor
|
I've put up a pull request to add @dgershman! 🎉 |
dgershman
force-pushed
the
version-output-format-json
branch
4 times, most recently
from
a36d180 to
3861916
Compare
dgershman
force-pushed
the
version-output-format-json
branch
from
3861916 to
3d0f07a
Compare
Member
|
Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds a flag to be able to return the response of the
versioncommand and return it as JSON.Why
I couldn't find an easier way to parse out what the latest version of K3S that K3D is using easily.
Implications
This adds new behavior and should likely not impact any existing other CLI commands. It does not modify any
pkginternals. No breaking changes.@all-contributors please add @dgershman for code