fix: call GatherEnvironmentInfo once in NodeAddToClusterMulti to avoid race condition causing error #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
force-pushed
the
fix_1410_node_create_race_condition_tools_node
branch
from
3b6c866
to
94a14f9
Compare
iwilltry42
requested changes
Jul 4, 2024
…d race condition causing error fixes k3d-io#1410 When multiple nodes are created, each call to NodeAddToCluster was calling GatherEnvironmentInfo, which was calling EnsureToolsNode() and then deleting the tools node. This causes some type of race condition. The work doesn't need to be done multiple times anyways, so just move it up to NodeAddToClusterMulti and do it once, before kicking off the goroutines.
In order to make it a non-breaking change for anyone import k3d in code and using this function directly, per https://github.com/k3d-io/k3d/pull/1411/files#r1665464968
ligfx
force-pushed
the
fix_1410_node_create_race_condition_tools_node
branch
from
94a14f9
to
7ea2bb5
Compare
iwilltry42
approved these changes
Jul 10, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1410
When multiple nodes are created, each call to NodeAddToCluster was calling GatherEnvironmentInfo, which was calling EnsureToolsNode() and then deleting the tools node. This causes some type of race condition. The work doesn't need to be done multiple times anyways, so just move it up to NodeAddToClusterMulti and do it once, before kicking off the goroutines.
(Also see #924 and #952 for previous similar issue)