Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] New --prune option for delete #178

Merged
merged 1 commit into from
Jan 30, 2020
Merged

[Feature] New --prune option for delete #178

merged 1 commit into from
Jan 30, 2020

Conversation

inercia
Copy link
Collaborator

@inercia inercia commented Jan 27, 2020 •
edited
Loading

New option, --prune, for delete. When forcing a delete, all the containers connected to the k3d network will be disconnected before removing the network.

@iwilltry42 iwilltry42 changed the title New --force option for delete [Feature] New --force option for delete Jan 28, 2020
@iwilltry42 iwilltry42 added the enhancement New feature or request label Jan 28, 2020
@iwilltry42 iwilltry42 self-assigned this Jan 28, 2020
iwilltry42
iwilltry42 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! 👍

main.go Outdated Show resolved Hide resolved
@inercia
New --prune option for delete
2ec3efd 
Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
@inercia inercia changed the title [Feature] New --force option for delete [Feature] New --prune option for delete Jan 30, 2020
iwilltry42
iwilltry42 approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@iwilltry42 iwilltry42 merged commit ba8f931 into k3d-io:master Jan 30, 2020
@inercia inercia deleted the inercia/forced_delete branch February 19, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees

@iwilltry42 iwilltry42

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inercia @iwilltry42