Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install.sh #256

Merged
merged 1 commit into from
May 29, 2020
Merged

Update install.sh #256

merged 1 commit into from
May 29, 2020

Conversation

izzatzr
Copy link
Contributor

@izzatzr izzatzr commented May 29, 2020 •
edited
Loading

change --version flag to v3 subcommand
fixes #255

@izzatzr
Update install.sh
898dbda 
change --version flag to new v3 subcommand
@iwilltry42
Copy link
Member

Hi @izzatzr , thanks for this PR 👍
Actually this is already fixed in e788614 by re-adding the --version flag. Though I think it shouldn't be a problem in any way :)

@iwilltry42 iwilltry42 self-requested a review May 29, 2020 10:59
iwilltry42
iwilltry42 approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwilltry42 iwilltry42 merged commit 0c5ca44 into k3d-io:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] k3d v3 install script --version flag
2 participants
@izzatzr @iwilltry42