Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Update loadbalancer if handling master nodes #258

Merged
merged 2 commits into from
Jun 3, 2020
Merged

[Enhancement] Update loadbalancer if handling master nodes #258

merged 2 commits into from
Jun 3, 2020

Conversation

iwilltry42
Copy link
Member

@iwilltry42 iwilltry42 commented Jun 2, 2020 •
edited
Loading

  • use idempotent UpdateKubeconfig which takes a fresh list of master
    nodes and uses it to update the loadbalancer
  • removeNode: use aforementioned function to update the loadbalancer
    config when removing a master node
  • startNode: Handled by the LB internally --> If it was created before, it should already be present in the LB
  • stopNode: Handled by the LB internally --> Backend going down should be handled by the LB

@iwilltry42
removeNode: update loadbalancer if master
f0d3389 
- use idempotent UpdateKubeconfig which takes a fresh list of master
nodes and uses it to update the loadbalancer
- removeNode: use aforementioned function to update the loadbalancer
config when removing a master node
@iwilltry42 iwilltry42 added enhancement New feature or request v3 labels Jun 2, 2020
@iwilltry42 iwilltry42 added this to the v3.0 - FROM scratch milestone Jun 2, 2020
@iwilltry42 iwilltry42 self-assigned this Jun 2, 2020
@iwilltry42
UpdateLoadbalancerConfig: deduplicate and warn if node is down
b28f93d 
- getCluster: now deduplicates the node list (i.e. overwrites existing
nodes in the list with "fresh" nodes and appends new ones)
- UpdateLoadbalancerConfig: print warning if "host not found in
upstream" returned by nginx after updating the config, as it's not a
failure per se, but shouldn't be ignored
@iwilltry42 iwilltry42 marked this pull request as ready for review June 3, 2020 10:54
@iwilltry42 iwilltry42 changed the title [WIP] [Enhancement] Update loadbalancer if handling master nodes [Enhancement] Update loadbalancer if handling master nodes Jun 3, 2020
@iwilltry42 iwilltry42 merged commit d0c24fe into master Jun 3, 2020
@iwilltry42 iwilltry42 deleted the update-loadbalancer-cases branch June 4, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iwilltry42 iwilltry42

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0 - FROM scratch
Development

Successfully merging this pull request may close these issues.
1 participant
@iwilltry42