Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] tools: use api version negotation when creating the docker client #679

Merged
merged 3 commits into from
Aug 18, 2021
Merged

[FIX] tools: use api version negotation when creating the docker client #679

merged 3 commits into from
Aug 18, 2021

Conversation

iwilltry42
Copy link
Member

Up to now, we didn't use API Version Negotiation when creating the docker client in the tools container. Due to this, it failed to create a client when running on a system with an old, unsupported API version.

Fixes #675

@iwilltry42 iwilltry42 added bug Something isn't working priority/high component/tools tools labels Jul 20, 2021
@iwilltry42 iwilltry42 added this to the v4.4.8 milestone Jul 20, 2021
@iwilltry42 iwilltry42 self-assigned this Jul 20, 2021
@iwilltry42
Copy link
Member Author

Tested with several versions of docker, including the one (19.03.12) mentioned in the original issue.
Installed bash and k3d inside the official dind image and tested the image import worklfow: confirmed that it failed with k3d v4.4.7 (and the corresponding k3d-tools container) -> replaced the k3d-tools binary in the running tools container and confirmed that it's working afterwards.

@iwilltry42 iwilltry42 merged commit 2faeda2 into main Aug 18, 2021
@iwilltry42 iwilltry42 deleted the fix/image-import-old-docker branch August 18, 2021 15:55
rancherio-gh-m pushed a commit that referenced this pull request Aug 18, 2021
@iwilltry42
commit 2faeda2
f7ec446 
Author: Thorsten Klein <iwilltry42@gmail.com>
Date:   Wed Aug 18 17:55:11 2021 +0200

    [FIX] tools: use api version negotation when creating the docker client (#679)
@iwilltry42 iwilltry42 mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iwilltry42 iwilltry42

Labels
bug Something isn't working component/tools tools priority/high
Projects
None yet
Milestone
v4.4.8
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot import images on NixOS 20.09
1 participant
@iwilltry42