Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] node create add host.k3d.internal entry to /etc/hosts + enhance NodeHooks #843

Merged
merged 2 commits into from
Nov 9, 2021
Merged

[Enhancement] node create add host.k3d.internal entry to /etc/hosts + enhance NodeHooks #843

merged 2 commits into from
Nov 9, 2021

Conversation

iwilltry42
Copy link
Member

Changes

  • nodeHooks: add Description field and Name()/Info() functions
  • nodeAddToCluster: add host.k3d.internal /etc/Hosts injection as postStartAction

Linked Issues/PRs

@iwilltry42 iwilltry42 added bug Something isn't working enhancement New feature or request priority/high component/main labels Nov 9, 2021
@iwilltry42 iwilltry42 added this to the v5.1.0 milestone Nov 9, 2021
@iwilltry42 iwilltry42 self-assigned this Nov 9, 2021
@iwilltry42 iwilltry42 merged commit ef139c9 into main Nov 9, 2021
@iwilltry42 iwilltry42 deleted the fix/node-create-hosts-entry branch November 9, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iwilltry42 iwilltry42

Labels
bug Something isn't working component/main enhancement New feature or request priority/high
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.

[BUG] no host.k3d.internal entry in /etc/hosts on newly added nodes
1 participant
@iwilltry42