Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serverlb should be created before using and restarted unless stopped #948

Merged
merged 4 commits into from
Jan 31, 2022
Merged

fix: serverlb should be created before using and restarted unless stopped #948

merged 4 commits into from
Jan 31, 2022

Conversation

wymli
Copy link
Contributor

@wymli wymli commented Jan 30, 2022

What

fix 2 problems

  1. serverlb should restart unless stopped
  2. serverLoadBalancer should be created before using in avoid of panic

Why

issue #947

Implications

fix corner case

iwilltry42
iwilltry42 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fixes an edge case that I didn't consider so far.
Thanks for your contribution @wymli 👍

pkg/client/cluster.go Outdated Show resolved Hide resolved
@iwilltry42 iwilltry42 added this to the v5.3.0 milestone Jan 31, 2022
@iwilltry42 iwilltry42 added the enhancement New feature or request label Jan 31, 2022
@iwilltry42 iwilltry42 merged commit 08d5ae6 into k3d-io:main Jan 31, 2022
@iwilltry42
Copy link
Member

iwilltry42 commented Feb 1, 2022 •
edited
Loading

For some reason, after merging this PR, k3d cluster ls returns ghost clusters with only the Loadbalancer and no name and k3d cluster delete fails to delete those clusters, because the loadbalancer node is missing the k3d.cluster label.. 🤔

UPDATE: fixed in fdd4dae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wymli @iwilltry42