Paddle direction parameter change #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default up/down speed change direction using the paddle press. Modify the default code so that the left paddle decreases the speed/sidetone and the right paddle increases the speed/sidetone. Could be more intuitive since 'knobs to the right' implies more... The new option OPTION_SWAP_PADDLE_PARAMETER_CHANGE_DIRECTION controls whether this swap is in effect or not. Unless the option is defined, then the default paddle direction will be implemented. There is no increase in the compiled code size, since only one piece of code is included in the final compiled code, as was the case before adding this option.
k3ng
added a commit
that referenced
this pull request
Dec 7, 2019
Resolved conflict and merged pull request 83 ( #83) Added OPTION_SWAP_PADDLE_PARAMETER_CHANGE_DIRECTION to feature and settings files of all hardware profiles (OPTION from pull request 83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option so that the left paddle decreases the speed/sidetone and the right paddle increases the speed/sidetone. Could be more intuitive since 'dials to the right' implies more of ...
The new option OPTION_SWAP_PADDLE_PARAMETER_CHANGE_DIRECTION controls whether this swap is in effect or not. Unless the option is defined, then the previously coded paddle directions will be implemented.
There is no increase in the compiled code size, since either way, only one piece of code is included in the final compiled code, as was the case before adding this option.