chore: add kube scheduler server args & plumb through to config #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. thanks! |
zawachte
approved these changes
Oct 2, 2023
|
thank you. is it worth a release for this? is that just a matter of adding a tag i think? anything i can do to help LMK |
Just created a release. Let's see how it goes ... I know that @ekarlso was still tinkering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i wanted to set some args on k3s using
--kube-scheduler-arg(see docs) but found that it wasn't exposed. in this PR i believe i have exposed that flag such that it will get plumbed through into the config file pushed onto the control plane hosts. i wasn't sure how to go about testing it so i'm hoping you can give me some pointers, or approve if you know it to be okay.