Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the curl command for preparing k3s images for Airgap #243

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix the curl command for preparing k3s images for Airgap #243

merged 1 commit into from
Feb 15, 2024

Conversation

rishinair11
Copy link
Contributor

@rishinair11 rishinair11 commented Feb 15, 2024 •
edited
Loading

Fixes #244

This fixes an invalid URL issue that curl throws.

$ sudo curl -L -O /var/lib/rancher/k3s/agent/images/k3s-airgap-images-amd64.tar.zst https://github.com/k3s-io/k3s/releases/download/v1.29.1-rc2%2Bk3s1/k3s-airgap-images-amd64.tar.zst
curl: (3) URL using bad/illegal format or missing URL
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

Since we are already passing the full path to the images.tar.zst, we can use -o instead of -O

@rishinair11
Fix the curl command for preparing k3s images for Airgap
07bbae1 
This fixes an invalid URL issue that `curl` throws.
Since we are already passing the full path to the images.tar.zst, we can use `-o` instead of `-O`

Signed-off-by: Rishi <alienware505@gmail.com>
@rishinair11 rishinair11 mentioned this pull request Feb 15, 2024
Closed
@brandond
Copy link
Member

yeah, -o is the correct option, not -O. You shouldn't need to quote the URL but it doesn't hurt anything.

brandond
brandond approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@dereknola dereknola merged commit 3231d6f into k3s-io:main Feb 15, 2024
3 checks passed
@rishinair11
Copy link
Contributor Author

Thank you team. I appreciate the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereknola dereknola dereknola approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

curl command for downloading k3s airgap images not working
3 participants
@rishinair11 @brandond @dereknola