Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SHA256 to sign packages instead of default SHA1 #32

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

brandond
Copy link
Member

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@vwbusguy
Copy link

vwbusguy commented Jun 6, 2022

I tested this out by building and running the centos8 container here and then installed the rpm with dnf in a centos:stream9 container and didn't get any complaints about the signature.

image

For good measure, I also installed it in a centos:stream8 container for good measure and also didn't have any problem:
image

I could be wrong, but I don't believe you need to force v3 signatures on EL8/9 as they both ship with yum4 out of box (yum 4 is a symlink to dnf 3) and the old DSA keys aren't supported anyway as of EL8. That said, I believe this PR is likely to work as-is.

# ls -l `which yum`
lrwxrwxrwx. 1 root root 5 Mar 24 09:08 /usr/bin/yum -> dnf-3

@brandond
Copy link
Member Author

I could be wrong, but I don't believe you need to force v3 signatures on EL8/9 as they both ship with yum4 out of box

The problem is not the yum version that it ships with, the problem is that the rpm macros on EL8 still don't use the correct signing algs by default. So you have to override the macros to get the signatures that the same distro wants to use when installing packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants