Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.29] windows changes #10115

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

HarrisonWAffel
Copy link
Contributor

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Harrison Affel <harrisonaffel@gmail.com>
@HarrisonWAffel HarrisonWAffel requested a review from a team as a code owner May 16, 2024 19:44
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 43.33%. Comparing base (1713931) to head (d910adf).

Files Patch % Lines
pkg/agent/config/config.go 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #10115      +/-   ##
================================================
- Coverage         50.01%   43.33%   -6.69%     
================================================
  Files               158      158              
  Lines             14032    14038       +6     
================================================
- Hits               7018     6083     -935     
- Misses             5693     6791    +1098     
+ Partials           1321     1164     -157     
Flag Coverage Δ
e2etests 36.14% <50.00%> (-10.46%) ⬇️
inttests 37.15% <12.50%> (+0.05%) ⬆️
unittests 16.57% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 1689846 into k3s-io:release-1.29 May 16, 2024
27 checks passed
This was referenced Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants