Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test-compat docker test to GHA #10414

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Jun 26, 2024

Proposed Changes

  • Move another docker test from drone to GHA matrix. Drops drone times by about 2.5min.

Before:
image

After:
image

Types of Changes

CI

Verification

Testing

Linked Issues

#10421

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner June 26, 2024 18:59
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.76%. Comparing base (f10cb29) to head (dd0370d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10414      +/-   ##
==========================================
- Coverage   41.78%   41.76%   -0.02%     
==========================================
  Files         177      177              
  Lines       14806    14802       -4     
==========================================
- Hits         6186     6182       -4     
+ Misses       7443     7441       -2     
- Partials     1177     1179       +2     
Flag Coverage Δ
e2etests 36.44% <ø> (+0.35%) ⬆️
inttests 36.98% <ø> (-0.04%) ⬇️
unittests 11.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dereknola dereknola changed the title [WIP] Move test-compat docker test to GHA Move test-compat docker test to GHA Jun 28, 2024
@dereknola dereknola merged commit 8f9ad1f into k3s-io:master Jul 9, 2024
29 checks passed
@dereknola dereknola deleted the docker_compat branch July 9, 2024 16:02
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 12, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 12, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 12, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 12, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Jul 15, 2024
* Move test-compat to GHA (#10414)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* For E2E upgrade test, automatically determine the channel to use (#10461)

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Jul 15, 2024
* Move test-compat to GHA (#10414)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* For E2E upgrade test, automatically determine the channel to use (#10461)

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Jul 15, 2024
* Move test-compat to GHA (#10414)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* For E2E upgrade test, automatically determine the channel to use (#10461)

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Jul 17, 2024
* Move test-compat to GHA (#10414)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* For E2E upgrade test, automatically determine the channel to use (#10461)

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
ludost pushed a commit to asimovo-platform/k3s that referenced this pull request Oct 2, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants