Add data-dir to uninstall and killall scripts
#10473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
changed the title
data-dir to uninstall and killall scripts
jakefhyde
force-pushed
the
10741-add-data-dir-to-uninstall-and-killall
branch
from
b615aba
to
e66e0e3
Compare
brandond
requested changes
Jul 9, 2024
jakefhyde
force-pushed
the
10741-add-data-dir-to-uninstall-and-killall
branch
from
e66e0e3
to
6e6fd3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10473 +/- ##
==========================================
- Coverage 47.87% 41.53% -6.35%
==========================================
Files 177 177
Lines 14830 14830
==========================================
- Hits 7100 6159 -941
- Misses 6384 7492 +1108
+ Partials 1346 1179 -167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
previously approved these changes
Jul 10, 2024
vitorsavian
previously approved these changes
Jul 10, 2024
|
I think we're good to go, unfortunately I just merged another change to the install script so you'll need to rebase to fix the checksum conflict :( |
Signed-off-by: Jake Hyde <jakefhyde@gmail.com>
jakefhyde
force-pushed
the
10741-add-data-dir-to-uninstall-and-killall
branch
from
6e6fd3d
to
0cdc30f
Compare
brandond
approved these changes
Jul 10, 2024
|
No backports necessary, as install script is served off master |
vitorsavian
approved these changes
Jul 10, 2024
dereknola
approved these changes
Jul 10, 2024
|
centos7 is dead; merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
K3S_DATA_DIRas an optional environment variable to thek3s-killallandk3s-uninstallscript generation withininstall.sh.Types of Changes
Bugfix
Verification
Installing K3s with a custom
data-dir(not/var/lib/rancher/k3s), and running the killall and uninstall scripts, verifying assets in/var/lib/rancher/k3sare properly removed.Testing
This is not currently covered by testing, though I would be happy to write an integration test if need be.
Linked Issues
#10471
User-Facing Change
Further Comments