Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure remotedialer kubelet connections use kubelet bind address #10480

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 10, 2024

Proposed Changes

Ensure that connections to the kubelet through the egress-selector (either local or via remotedialer) use the correct kubelet bind address.

We have long overridden the kubelet address to the loopback address when dialing via the remotedialer tunnel, and ensured that the kubelet always binds to an ipv4 or ipv6 wildcard address. We broke this in #10019 when we wired the --bind-address flag up to the kubelet --address flag by way of the ListenAddress field.

This is blocked on:

Types of Changes

bugfix

Verification

  1. Set --bind-address on a server or agent node
  2. Note that kubectl logs works properly to retrieve logs from pods on that node

Testing

Linked Issues

User-Facing Change

Fixed an issue where setting the `--bind-address` flag to a non-loopback or wildcard address would prevent `kubectl logs` from working properly.

Further Comments

@brandond brandond requested a review from a team as a code owner July 10, 2024 00:14
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.57%. Comparing base (4204248) to head (b450ce5).
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/agent/tunnel/tunnel.go 83.33% 1 Missing and 1 partial ⚠️
pkg/daemons/control/tunnel.go 50.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4204248) and HEAD (b450ce5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4204248) HEAD (b450ce5)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10480      +/-   ##
==========================================
- Coverage   47.16%   41.57%   -5.59%     
==========================================
  Files         177      177              
  Lines       14830    14839       +9     
==========================================
- Hits         6995     6170     -825     
- Misses       6532     7485     +953     
+ Partials     1303     1184     -119     
Flag Coverage Δ
e2etests 36.42% <75.00%> (-9.45%) ⬇️
inttests 19.91% <0.00%> (-0.02%) ⬇️
unittests 11.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shakibamoshiri

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants