Fix: Add $SUDO prefix to transactional-update commands in install script #10531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to update the install.sh.sha256sum |
|
@dereknola Thanks for the hint, I have updated the checksum file as requested. |
dereknola
previously approved these changes
Aug 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10531 +/- ##
==========================================
- Coverage 49.56% 43.50% -6.06%
==========================================
Files 179 179
Lines 14955 14955
==========================================
- Hits 7412 6506 -906
- Misses 6184 7254 +1070
+ Partials 1359 1195 -164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
force-pushed
the
add-sudo-to-transactional-update
branch
from
f382b86
to
1093cf0
Compare
This commit addresses an issue in the k3s install script where the transactional-update commands did not include the $SUDO variable. This omission caused the script to fail if sudo was not used. Adding the $SUDO prefix ensures that the script runs correctly in all environments. Signed-off-by: ChrisBeaker <christian.siebigteroth@suse.com> Signed-off-by: Derek Nola <derek.nola@suse.com>
This commit addresses an issue in the k3s install script where the transactional-update commands did not include the $SUDO variable. This omission caused the script to fail if sudo was not used. Adding the $SUDO prefix ensures that the script runs correctly in all environments. Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
add-sudo-to-transactional-update
branch
from
1093cf0
to
8022d3e
Compare
dereknola
approved these changes
Aug 12, 2024
brandond
approved these changes
Aug 12, 2024
ludost
pushed a commit
to asimovo-platform/k3s
that referenced
this pull request
Oct 2, 2024
…ipt (k3s-io#10531) * Fix: Add $SUDO prefix to transactional-update commands in install script This commit addresses an issue in the k3s install script where the transactional-update commands did not include the $SUDO variable. This omission caused the script to fail if sudo was not used. Adding the $SUDO prefix ensures that the script runs correctly in all environments. Signed-off-by: ChrisBeaker <christian.siebigteroth@suse.com> Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This commit addresses an issue in the k3s install script where the transactional-update commands did not include the $SUDO variable. This omission caused the script to fail if sudo was not used. Adding the $SUDO prefix ensures that the script runs correctly in all environments.
Types of Changes
Bugfix
Verification
Aligned to existing commands already using sudo
Testing
Linked Issues
#10530
User-Facing Change
Further Comments