fixes #3264 - unmount CSI plugins on k3s-killall.sh #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: angelnu <git@angelnucom>
brandond
approved these changes
May 4, 2021
briandowns
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Unmount kubelet plugin folder on k3s-uninstall.sh. This is required to prevent data lost as seen in #3264
Types of Changes
Bugfix
Verification
Real test described in #3264
Dummy test would be just doing a manual mount in /var/lib/kubelet/plugins and ensure is unmounted by k3s-killall.sh.
Linked Issues
#3264
Further Comments
You might consider unmounting any mount points under /var/lib/kubelet instead to catch any potential new future new folders.