-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set duration to second #4231
set duration to second #4231
Conversation
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with suggestions for the flag text)
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4231 +/- ##
==========================================
+ Coverage 11.19% 11.54% +0.34%
==========================================
Files 135 135
Lines 9277 9277
==========================================
+ Hits 1039 1071 +32
+ Misses 8020 7978 -42
- Partials 218 228 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs brian.downs@gmail.com
Proposed Changes
Types of Changes
Verification
Linked Issues
#4205
User-Facing Change
Further Comments