Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set duration to second #4231

Merged
merged 3 commits into from
Oct 15, 2021
Merged

set duration to second #4231

merged 3 commits into from
Oct 15, 2021

Conversation

briandowns
Copy link
Contributor

Signed-off-by: Brian Downs brian.downs@gmail.com

Proposed Changes

Types of Changes

Verification

Linked Issues

#4205

User-Facing Change


Further Comments

Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns briandowns requested a review from a team October 15, 2021 20:40
@briandowns briandowns self-assigned this Oct 15, 2021
Signed-off-by: Brian Downs <brian.downs@gmail.com>
pkg/cli/cmds/server.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dweomer dweomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with suggestions for the flag text)

Signed-off-by: Brian Downs <brian.downs@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #4231 (21e5cab) into master (0452f01) will increase coverage by 0.34%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4231      +/-   ##
==========================================
+ Coverage   11.19%   11.54%   +0.34%     
==========================================
  Files         135      135              
  Lines        9277     9277              
==========================================
+ Hits         1039     1071      +32     
+ Misses       8020     7978      -42     
- Partials      218      228      +10     
Flag Coverage Δ
inttests 0.66% <0.00%> (?)
unittests 11.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cli/cmds/etcd_snapshot.go 0.00% <ø> (ø)
pkg/cli/cmds/server.go 0.00% <0.00%> (ø)
pkg/flock/flock_unix.go 20.00% <0.00%> (+20.00%) ⬆️
tests/util/cmd.go 42.02% <0.00%> (+42.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0452f01...21e5cab. Read the comment docs.

@briandowns briandowns merged commit e11a4bf into k3s-io:master Oct 15, 2021
briandowns added a commit to briandowns/k3s that referenced this pull request Oct 15, 2021
Signed-off-by: Brian Downs <brian.downs@gmail.com>
briandowns added a commit to briandowns/k3s that referenced this pull request Oct 15, 2021
Signed-off-by: Brian Downs <brian.downs@gmail.com>
briandowns added a commit to briandowns/k3s that referenced this pull request Oct 15, 2021
Signed-off-by: Brian Downs <brian.downs@gmail.com>
briandowns added a commit to briandowns/k3s that referenced this pull request Oct 15, 2021
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants