Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean E2E VMs before testing #7109

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Clean E2E VMs before testing #7109

merged 2 commits into from
Mar 22, 2023

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Mar 18, 2023

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

  • Detect if any lingering server or agent VMs are still around and clean them up manually before proceeding with E2E testing.
  • This addresses an issue where a Drone run would get cancelled or core dump fail, preventing the cleanup at the end from running. Now we run it at the beginning to ensure clean test runs.

Types of Changes

Verification

CI now passes.

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner March 18, 2023 00:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (561ec05) 9.66% compared to head (99a4b10) 9.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #7109   +/-   ##
======================================
  Coverage    9.66%   9.66%           
======================================
  Files         147     147           
  Lines       10766   10766           
======================================
  Hits         1040    1040           
  Misses       9508    9508           
  Partials      218     218           
Flag Coverage Δ
unittests 9.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola changed the title Clean e2e Clean E2E VMs before testing Mar 21, 2023
@dereknola dereknola merged commit c97370b into k3s-io:master Mar 22, 2023
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 29, 2023
* Cleanup VMs proper

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 29, 2023
* Cleanup VMs proper

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Apr 28, 2023
* Cleanup VMs proper

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Apr 28, 2023
* Cleanup VMs proper

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request May 1, 2023
* Initial drone vagrant pipeline

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Build e2e test image
* Add ci flag to secretsencryption
* Fix vagrant log on secretsencryption
* Add cron conformance pipeline
* Add string output for nodes
* Switch snapshot restore for upgrade cluster

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Added IPv6 check and agent restart on e2e test utils

Signed-off-by: Roberto Bonafiglia <roberto.bonafiglia@suse.com>

* Drone: Cleanup E2E VMs on test panic (#7104)

* Cleanup leftover VMs in E2E pipeline

* Clean E2E VMs before testing (#7109)

* Cleanup VMs proper

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Dont run most pipelines on nightly cron
* Improve RunCmdOnNode error
* Pin upgradecluster to v1.24

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Roberto Bonafiglia <roberto.bonafiglia@suse.com>
Co-authored-by: Roberto Bonafiglia <roberto.bonafiglia@suse.com>
@dereknola dereknola deleted the clean_e2e branch May 2, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants