Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Fix on-demand snapshots timing out; not honoring folder #9994

Conversation

brandond
Copy link
Member

@brandond brandond commented Apr 22, 2024

Proposed Changes

  • Backport Fix on-demand snapshots timing out; not honoring folder #9984
  • Fix on-demand snapshots not honoring folder
    Also fix etcd s3 tests to actually check that the files are saved to s3 🙃
  • Fix 10 second etcd-snapshot request timeout
    The default clientaccess request timeout is too short. Wait longer by default, and add the s3 timeout if s3 is enabled.

Types of Changes

bugfix

Verification

See linked issue

Testing

yes

Linked Issues

User-Facing Change

Further Comments

Also fix etcd s3 tests to actually check that the files are saved to s3 🙃

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 5b431ca)
The default clientaccess request timeout is too short. Wait longer by default, and add the s3 timeout if s3 is enabled.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit d3b6054)
@brandond brandond requested a review from a team as a code owner April 22, 2024 15:50
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 36.24%. Comparing base (b33e710) to head (90db403).

Files Patch % Lines
pkg/etcd/snapshot_handler.go 0.00% 4 Missing ⚠️
pkg/cli/etcdsnapshot/etcd_snapshot.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #9994      +/-   ##
================================================
- Coverage         40.74%   36.24%   -4.50%     
================================================
  Files               158      155       -3     
  Lines             17320    13868    -3452     
================================================
- Hits               7057     5027    -2030     
+ Misses             9020     7864    -1156     
+ Partials           1243      977     -266     
Flag Coverage Δ
e2etests 36.24% <36.36%> (-9.88%) ⬇️
inttests ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond
Copy link
Member Author

virtualbox image for btrfs test appears to be broken; merging

@brandond brandond merged commit 8eed41d into k3s-io:release-1.28 Apr 22, 2024
26 of 27 checks passed
@brandond brandond deleted the fix-etcd-snapshot-save-s3-prefix_release-1.28 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants