Update function signature on nocgo stub #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ibuildthecloud any tips on how can this be tested for both cases (with and without cgo) to avoid this from happening in the future? |
solmyrcan
added a commit
to solmyrcan/kine
that referenced
this pull request
Mar 22, 2023
solmyrcan
added a commit
to solmyrcan/kine
that referenced
this pull request
Mar 25, 2023
solmyrcan
added a commit
to solmyrcan/kine
that referenced
this pull request
Mar 25, 2023
solmyrcan
added a commit
to solmyrcan/kine
that referenced
this pull request
Mar 28, 2023
solmyrcan
added a commit
to solmyrcan/kine
that referenced
this pull request
Mar 28, 2023
solmyrcan
added a commit
to solmyrcan/kine
that referenced
this pull request
Mar 29, 2023
* Schema incremental improve (k3s-io#19) * Initial test for compaction, to continue * completed benchmark - initial * direct call to compact * channel implementation for signalling compact event from test * New DoCompact(), no new channels, size remains same * commented out few prints * Some tidy-up * more tidy-up * More clean-up * Schema incremental improve (k3s-io#19) * done merge with local master * Compaction size fails * Modification to DB size method * Common compaction method, more brief compact() * Common compaction method, more brief compact() * remoted the loop tag * removed redundant continue in compactor and addressed review comments * tidy up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix signature of
sqlite.Newfunction updated on c395d22.