Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove star imports in heiko-cli #28

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

blarz
Copy link
Contributor

@blarz blarz commented Aug 8, 2019

No description provided.

@noqqe
Copy link
Member

noqqe commented Aug 9, 2019

Did you test this?

I had all kinds of problems with imports. I cannot remember really why or what it exactly was.

@blarz
Copy link
Contributor Author

blarz commented Aug 9, 2019

I tested it on my local setup and it still works.

I was just going through the list of flake8 warnings, removed the star imports and imported everything that was red underlined after that ;)

@noqqe noqqe merged commit 6cb6ae8 into k4cg:master Aug 9, 2019
@noqqe
Copy link
Member

noqqe commented Aug 9, 2019

thats enough for me :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants