Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variables in credit setter error log #45

Merged
merged 1 commit into from
Sep 8, 2019
Merged

Fix variables in credit setter error log #45

merged 1 commit into from
Sep 8, 2019

Conversation

blarz
Copy link
Contributor

@blarz blarz commented Sep 5, 2019

No description provided.

@blarz blarz requested a review from chca42 September 5, 2019 20:43
@chca42
Copy link
Contributor

chca42 commented Sep 8, 2019

Thanks for spotting this error. However, the message does not yet match the value - "add_credits" only contains the increment not the requested new total. Can you also change the text to something like "Could not add XY credits for ..."?

@blarz
Copy link
Contributor Author

blarz commented Sep 8, 2019

Thanks for spotting this error. However, the message does not yet match the value - "add_credits" only contains the increment not the requested new total. Can you also change the text to something like "Could not add XY credits for ..."?

You're right, I got that wrong, thanks! Fixed the log message.

@chca42
Copy link
Contributor

chca42 commented Sep 8, 2019

Thx.

@chca42 chca42 merged commit 13d7ca0 into k4cg:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chca42 chca42 Awaiting requested review from chca42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blarz @chca42