Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serveral improvements for migrate.py #70

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Serveral improvements for migrate.py #70

merged 3 commits into from
Oct 31, 2019

Conversation

noqqe
Copy link
Member

@noqqe noqqe commented Oct 31, 2019

The improvements are:

  • Make migration database configurable
  • Validation of the sqlites file existence
  • Reorder the questions during migration (ask if admin first)
  • Rename sq to matomat_db according to PEP Variables
  • Convert to .format() instead of % for string variable concatination
  • Reduce code duplication in add/withdraw function calls of credits after migration

@noqqe noqqe requested review from chca42 and blarz October 31, 2019 19:25
blarz
blarz requested changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@blarz blarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor issues, other than that it looks good to me

heiko/migrate.py Outdated Show resolved Hide resolved
heiko/migrate.py Show resolved Hide resolved
@noqqe noqqe requested a review from blarz October 31, 2019 20:28
blarz
blarz approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@blarz blarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go!

@noqqe noqqe merged commit 9dbd837 into master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blarz blarz blarz approved these changes

@chca42 chca42 Awaiting requested review from chca42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noqqe @blarz