Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting section rework #71

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Accounting section rework #71

merged 1 commit into from
Oct 31, 2019

Conversation

noqqe
Copy link
Member

@noqqe noqqe commented Oct 31, 2019

The accounting config section was in camelCase while all other config items are separated words by underscore.

While doing this I found that the parsing was very confusing and unnecessary.

@noqqe noqqe requested review from blarz and chca42 October 31, 2019 19:43
Copy link
Contributor

@blarz blarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice refactoring!

@noqqe noqqe merged commit 3b15d4a into master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants