Do not group upgrades of dependencies on major version 0 #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaguas
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev and
jkremser
as code owners
Signed-off-by: abaguas <andre.aguas@protonmail.com>
abaguas
force-pushed
the
renovatebot/major0
branch
from
aea7b38
to
79278da
Compare
ytsarev
reviewed
Jun 22, 2024
There was a problem hiding this comment.
Just for clarity, why are we focusing exactly on version 0.x and not on any minor(as in https://semver.org/) as 1.x or y.x ?
Because packages on version |
Got it, I am not sure if this assumption is true to all packages but it's definitely close to reality, so let's sort them out this way. Thanks a lot for the contribution! |
ytsarev
approved these changes
Jun 22, 2024
abaguas
added a commit
to abaguas/k8gb
that referenced
this pull request
Jun 26, 2024
Since k8gb-io#1610 was merged the number of PRs created by renovate increased, as bumps of libraries on version 0.x are handled in a dedicated PR. The maximum number of concurrent PRs is 5 which results in rate-limiting: k8gb-io#1048. The proposal is to increase it to 15 so that we can see and tackle the PRs containing potential breaking changes. In addition, the `update all non-major dependencies` group should very rarely contain breaking changes (k8gb-io#1052) so I proposal to turn on automerge (if the pipeline is green ofc). This should save the maintainers some precious minutes.
abaguas
added a commit
to abaguas/k8gb
that referenced
this pull request
Jun 26, 2024
Since k8gb-io#1610 was merged the number of PRs created by renovate increased, as bumps of libraries on version 0.x are handled in a dedicated PR. The maximum number of concurrent PRs is 5 which results in rate-limiting: k8gb-io#1048. The proposal is to increase it to 15 so that we can see and tackle the PRs containing potential breaking changes. In addition, the `update all non-major dependencies` group should very rarely contain breaking changes (k8gb-io#1052) so I proposal to turn on automerge (if the pipeline is green ofc). This should save the maintainers some precious minutes. Signed-off-by: abaguas <andre.aguas@protonmail.com>
ytsarev
pushed a commit
that referenced
this pull request
Jun 27, 2024
Since #1610 was merged the number of PRs created by renovate increased, as bumps of libraries on version 0.x are handled in a dedicated PR. The maximum number of concurrent PRs is 5 which results in rate-limiting: #1048. The proposal is to increase it to 15 so that we can see and tackle the PRs containing potential breaking changes. In addition, the `update all non-major dependencies` group should very rarely contain breaking changes (#1052) so I proposal to turn on automerge (if the pipeline is green ofc). This should save the maintainers some precious minutes. Signed-off-by: abaguas <andre.aguas@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a Renovate Bot rule grouping all minor and patch dependency updates in a single pull request. However, packages that follow SemVer are allowed to make breaking changes in any
0.xversion. This led to a situation where the PR to bump the groupall non-major dependencieshas a red pipeline (#1052) which cannot be merged since many months.This PR attempts to fix the problem by excluding version
0.xfrom theall non-major dependenciesgroup (as documented in https://docs.renovatebot.com/configuration-options/#matchupdatetypes). These updates will instead be handled in a dedicated PR. This should prevent benign minor and patch upgrades from being blocked as well as allow us to easily identify the dependency bumps that introduce breaking changes.Note: the preset group:allNonMajor is removed since we are not using it anymore, as we override it.