fix(promises): handle errors

kKen94 · Aug 18, 2020 · 9e6f87a · 9e6f87a
1 parent 8282af3
commit 9e6f87a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/projects/lib/src/lib/bar/bar.service.ts b/projects/lib/src/lib/bar/bar.service.ts
@@ -21,7 +21,7 @@ export class BarService {
     clearInterval(this.interval);
   }
 
-  complete(): Promise<unknown> {
+  async complete(): Promise<unknown> {
     this.set(99);
     return new Promise(resolve => {
       setTimeout(() => {

diff --git a/projects/lib/src/lib/ngx-progress.service.ts b/projects/lib/src/lib/ngx-progress.service.ts
@@ -55,10 +55,15 @@ export class NgxProgressService {
       this.progressCount--;
     }
     if (this.progressCount === 0) {
-      this.barService.complete().then(() => {
-        this.isStarted = false;
-        this.endEmitter.next();
-      });
+      this.barService
+        .complete()
+        .then(() => {
+          this.isStarted = false;
+          this.endEmitter.next();
+        })
+        .catch(error => {
+          throw new Error(error);
+        });
     }
   }
 
@@ -76,10 +81,15 @@ export class NgxProgressService {
    * Force the end of the progress
    */
   terminate(): void {
-    this.barService.complete().then(() => {
-      this.isStarted = false;
-      this.endEmitter.next();
-    });
+    this.barService
+      .complete()
+      .then(() => {
+        this.isStarted = false;
+        this.endEmitter.next();
+      })
+      .catch(error => {
+        throw new Error(error);
+      });
   }
 
   /**