Move FormData serialization to occur only on http2 requests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpwspoon
reviewed
Jul 25, 2017
| @@ -322,7 +322,7 @@ function enableXHROverH2(XMLHttpRequest, configuration) { | |||
| var self = this; | |||
|
|
|||
| // Also fix support for node-http2 FormData | |||
| body = serializeXhrBody(xhrInfo, body); | |||
There was a problem hiding this comment.
Please move with or remove corresponding comment
// Also fix support for node-http2 FormData
|
Closing in favor of #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.