Extract ui components from ImageUpload component #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit e16ecc8 and detected 10 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 45.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 16.3% (3.5% change). View more on Code Climate. |
sandercamp
changed the base branch from
refactor/ui-improvements
to
refactor/ui-components
sandercamp
changed the title
marcianosr
reviewed
Nov 14, 2023
| } | ||
|
|
||
| .dropzone:focus { | ||
| outline: none; |
There was a problem hiding this comment.
Would this be a problem a11y wise?
marcianosr
reviewed
Nov 14, 2023
|
|
||
| type DropzoneProps = { | ||
| label?: string | ||
| [x: string]: any; // Plugin context determines which props are needed |
There was a problem hiding this comment.
Would unknown maybe better iso of any?
marcianosr
approved these changes
Nov 14, 2023
|
Approved with some comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear
Why
Explain why these things are changes. This explanation is for your colleagues and your future self.
Code Review
Please consider the following checklist when reviewing this Pull Request.
More background and details here.