Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump re2 version to 2024-07-02 #3

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: bump re2 version to 2024-07-02 #3

wants to merge 9 commits into from
+93 −5

Conversation

kachick
Copy link
Owner

@kachick kachick commented Apr 17, 2024

@kachick kachick marked this pull request as draft April 17, 2024 07:48
@kachick
Copy link
Owner Author

kachick commented Apr 17, 2024

abseil/abseil-cpp#693

@kachick kachick mentioned this pull request Apr 18, 2024
Closed
@kachick kachick changed the title chore: bump re2 version to 2024-04-01 feat: bump re2 version to 2024-04-01 Apr 18, 2024
@kachick
Copy link
Owner Author

kachick commented Sep 25, 2024 •
edited
Loading

Hardcoded the abseil nix store path as -I /nix/store/bm0za9fkf2hlzy1kab0229k3iy5xzxfj-abseil-cpp-20240116.2/include in makefile made progress, but it makes many errors such as

wasm-ld: error: /tmp/emscripten_temp_tbdj0h_g/bitstate_1.o: undefined symbol: absl::lts_20240116::log_internal::LogMessage::LogMessage(char const*, int, absl::lts_20240116::LogSeverity)

Looks like similar problem as protocolbuffers/protobuf#16314 (comment)

@kachick
Copy link
Owner Author

kachick commented Sep 25, 2024

llvm/llvm-project#102443
abseil/abseil-cpp#1743
abseil/abseil-cpp#1747

@kachick kachick changed the title feat: bump re2 version to 2024-04-01 feat: bump re2 version to 2024-07-02 Sep 25, 2024
kachick
kachick commented Sep 25, 2024
View reviewed changes
flake.nix
emscripten # `emcc`
];
# LD_LIBRARY_PATH = lib.makeLibraryPath [ pkgs.abseil-cpp ];
# propagatedBuildInputs = [ pkgs.abseil-cpp pkgs.icu ];
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NixOS/nixpkgs/blob/84bd184f8179ff6999d6d10e6b0ca575b4118674/pkgs/development/libraries/re2/default.nix#L44

@kachick
Copy link
Owner Author

kachick commented Sep 25, 2024

They are still using abseil 20240116.2 instead of 20240722.0 https://github.com/google/re2/blob/6dcd83d60f7944926bfd308cc13979fc53dd69ca/MODULE.bazel#L16

If I need to specify version, pick from https://github.com/NixOS/nixpkgs/tree/15ddcc64cdd2587e58d90334a9cfa49de308b7c7/pkgs/development/libraries/abseil-cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
🛸
Status: 🤷‍♂️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kachick