Marmalade marketplace #2201
Merged
Marmalade marketplace #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…ent-utils/marmalade-functions
…a-community/kadena.js into feat/marmalade-marketplace
alber70g
approved these changes
May 29, 2024
There was a problem hiding this comment.
We can remove these, and the ico and webp files if not relevant
There was a problem hiding this comment.
Removed vercel.svg and replaced the ico. The no-image.webp is being used as a fallback image.
wooglie
reviewed
May 29, 2024
packages/apps/marmalade-marketplace/src/components/Token/index.tsx
Outdated
Show resolved
Hide resolved
wooglie
approved these changes
May 29, 2024
alber70g
approved these changes
May 30, 2024
There was a problem hiding this comment.
This one should probably in .gitignore? If you want to set some requirements to the execution environment you can add engines in the package.json
| "@types/webpack-env": "^1.18.5", | ||
| "@vanilla-extract/css": "1.14.2", | ||
| "@vanilla-extract/next-plugin": "2.4.0", | ||
| "axios": "^1.6.8", |
There was a problem hiding this comment.
Any reason we're not using fetch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work in progress of the Marmalade marketplace app