Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-render and publish composite #130

Closed
bitomule opened this issue Aug 5, 2015 · 7 comments
Closed

Fast-render and publish composite #130

bitomule opened this issue Aug 5, 2015 · 7 comments

Comments

@bitomule
Copy link

bitomule commented Aug 5, 2015

Are those 2 packages compatible? I'm migrating to flow router and tried using fast-render too but I get errors caused publishComposite null returns. For example:

if(!this.userId){
return
}

It works well if I return a cursor instead of undefined or null. Is there a better way to work with this?
@arunoda
Copy link
Contributor

arunoda commented Aug 6, 2015

What are the errors you are getting?

@bitomule
Copy link
Author

bitomule commented Aug 6, 2015

I get 2 different errors as soon as I add fast-render package:

Publish handler for null sent no ready signal

and

RangeError: Maximum call stack size exceeded

@arunoda
Copy link
Contributor

arunoda commented Aug 6, 2015

Is there any way you can isolate that code block and send it to me.
On 2015 අගෝ 6, බ්‍රහස් at පෙ.ව. 11.51 bitomule notifications@github.com
wrote:

I get 2 different errors as soon as I add fast-render package:

Publish handler for null sent no ready signal

and

RangeError: Maximum call stack size exceeded


Reply to this email directly or view it on GitHub
#130 (comment)
.

@bitomule
Copy link
Author

bitomule commented Aug 6, 2015

I think I've found the issues:

  • I'm using es6 for my model classes and I had some get variableName(). That's a really bad idea because cursors included that data in each document. So a get relatedData() using other cursors inside causes the stack error and multiple other issues I had.
  • The other issue, the one that's still causing the "Publish handler for null sent no ready signal" is related to konecty:user-presence. I'm going to create an issue there too and reference this issue. Removing that package removes the error.

The only question left I have is: does that error cause any issues inside fast-render? Can I ignore it until is fixed on user-presence side or it could cause fast-render to crash.

Thanks @arunoda

@arunoda
Copy link
Contributor

arunoda commented Aug 6, 2015

I really not sure without looking at a sample code.
On 2015 අගෝ 6, බ්‍රහස් at ප.ව. 2.50 bitomule notifications@github.com
wrote:

I think I've found the issues:

I'm using es6 for my model classes and I had some get variableName().
That's a really bad idea because cursors included that data in each
document. So a get relatedData() using other cursors inside causes the
stack error and multiple other issues I had.

The other issue, the one that's still causing the "Publish handler for
null sent no ready signal" is related to konecty:user-presence. I'm going
to create an issue there too and reference this issue. Removing that
package removes the error.

The only question left I have is: does that error cause any issues inside
fast-render? Can I ignore it until is fixed on user-presence side or it
could cause fast-render to crash.

Thanks @arunoda https://github.com/arunoda


Reply to this email directly or view it on GitHub
#130 (comment)
.

@bitomule
Copy link
Author

bitomule commented Aug 6, 2015

I've removed user-presence and added it again and now I don't see the error. Maybe an update fixed it. I don't think the issue is on fast render side. Thanks @arunoda

@arunoda
Copy link
Contributor

arunoda commented Aug 6, 2015

Okay. Great.

On Thu, Aug 6, 2015 at 4:50 PM bitomule notifications@github.com wrote:

I've removed user-presence and added it again and now I don't see the
error. Maybe an update fixed it. I don't think the issue is on fast render
side. Thanks @arunoda https://github.com/arunoda


Reply to this email directly or view it on GitHub
#130 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants