Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix system tests #97

Merged
merged 2 commits into from
Oct 8, 2023
Merged

test: fix system tests #97

merged 2 commits into from
Oct 8, 2023

Conversation

kadru
Copy link
Owner

@kadru kadru commented Oct 8, 2023

update multiple gems to fix systems tests:

  • rails from 7.0.4 to 7.0.8
    fix unkown argument capabilties
  • capybara from 3.35.5 to 3.39.2
    fix usage of Selenium logger
  • selenium-webdriver 4.1.0 to 4.13.1
    handle webdriver download
  • remove webdrivers
    because selenium-webdriver will handle drivers download
  • fix flaky tests vistor sign_up spec

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (db719cc) 89.00% compared to head (34d2470) 98.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   89.00%   98.39%   +9.38%     
==========================================
  Files          34       34              
  Lines         373      373              
  Branches       31       31              
==========================================
+ Hits          332      367      +35     
+ Misses         41        6      -35     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kadru kadru merged commit 7c234a4 into master Oct 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant