Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: SR: Impl sorting #389

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FE: SR: Impl sorting #389

wants to merge 2 commits into from

Conversation

svrmnk
Copy link
Contributor

@svrmnk svrmnk commented May 15, 2024

What changes did you make? (Give an overview)

Fixes #208

I implemented sorting to the table at the Schema registry tab

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@svrmnk svrmnk requested a review from a team as a code owner May 15, 2024 10:03
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 15, 2024
@Mgrdich
Copy link
Contributor

Mgrdich commented May 16, 2024

@Haarolean is sorting going to be only on the frontend side ?

@Haarolean
Copy link
Member

@Haarolean is sorting going to be only on the frontend side ?

nope, the issue has the backend label which we need first to make it work with pagination

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes and removed status/triage/manual Manual triage in progress labels May 16, 2024
@Haarolean Haarolean changed the title issue 208: implement sorting to the table at the Schema registry tab FE: SR: Impl sorting May 16, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/frontend Related to frontend changes status/pending-backend status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SR: Implement sorting
3 participants