Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Fix white dot on the "Key Serde" dropdown #395

Merged
merged 1 commit into from
May 20, 2024
Merged

FE: Fix white dot on the "Key Serde" dropdown #395

merged 1 commit into from
May 20, 2024

Conversation

sierikov
Copy link
Contributor

Increased z-index of select's dropdown element. Closes #394. Tested manually.

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)
image

@sierikov sierikov requested a review from a team as a code owner May 16, 2024 12:36
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 16, 2024
github-actions[bot]
github-actions bot reviewed May 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi sierikov! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@sierikov sierikov mentioned this pull request May 16, 2024
Closed
4 tasks
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/ux User experiense issues and removed status/triage/manual Manual triage in progress labels May 16, 2024
@Haarolean Haarolean requested a review from Mgrdich May 16, 2024 13:14
@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt and removed type/bug Something isn't working labels May 20, 2024
@Haarolean Haarolean changed the title Increase z-index of Select Dropdown element FE: Fix white dot on the "Key Serde" dropdown May 20, 2024
@Haarolean Haarolean merged commit 19e95fe into kafbat:main May 20, 2024
46 of 47 checks passed
@Haarolean
Copy link
Member

@sierikov thanks for your first contribution to kafbat ui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Mgrdich Mgrdich Mgrdich approved these changes

Assignees
No one assigned
Labels
area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

White dot on the "Key Serde" dropdown
3 participants
@sierikov @Haarolean @Mgrdich